This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Add configuration for rate-limiting of logins, replacing hardcoded limits #3090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reivilibre
force-pushed
the
rei/rate_limiting_configuration
branch
from
b2e24f3 to
11abd7a
Compare
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
6100645
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6ca11e57.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://rei-rate-limiting-configurat.matrix-authentication-service-docs.pages.dev |
sandhose
reviewed
Aug 7, 2024
| // period must be at least 1 nanosecond according to the governor library | ||
| if recip < 1.0e-9 || !recip.is_finite() { | ||
| return Some(figment::error::Error::custom( | ||
| "`per_second` must be a number that is more than zero and less than 1_000_000_000 (1e9)", |
There was a problem hiding this comment.
hmm that error message doesn't look right?
There was a problem hiding this comment.
Aah, recip < 1.0e-9 is 'more than zero' and !recip.is_finite() is 'less than 1e9'?
There was a problem hiding this comment.
heheh, not quite, recip < 1.0e-9 means that per_second > 1e9, and is_finite guards against infinities and NaNs.
There was a problem hiding this comment.
maybe I should apply the validation on the input, I just didn't want to misthink the divisions and have it fail to create a quota with the numbers.
There was a problem hiding this comment.
actually I think what you did is fine, since it's closer to what governor does internally, I just missed the .recip()
reivilibre
force-pushed
the
rei/rate_limiting_configuration
branch
from
df967f6 to
8df3ec4
Compare
sandhose
approved these changes
Aug 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3013 to make it configurable.