feat(media): support async upload #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjbvr
force-pushed
the
bnjbvr/async-media
branch
from
553c2e0 to
c5f8e17
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4165 +/- ##
==========================================
- Coverage 84.85% 84.83% -0.02%
==========================================
Files 269 269
Lines 28916 28937 +21
==========================================
+ Hits 24536 24549 +13
- Misses 4380 4388 +8 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Oct 23, 2024
| // Unfortunately, the spec says a server will return 404 for either an expired MXC | ||
| // ID or a non-existing MXC ID. Do a best-effort guess to recognize an expired MXC | ||
| // ID based on the error string, which will work with Synapse (as of 2024-10-23). | ||
| Some(ErrorKind::Unknown) if err.to_string().contains("expired") => { |
Changelog: Support for preallocated media content URI has been added in `Media::create_content_uri()`, and uploading the content for such a preallocated URI is possible with `Media::upload_preallocated()`.
bnjbvr
force-pushed
the
bnjbvr/async-media
branch
from
c5f8e17 to
0ec1d24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for preallocated a MXC ID and using it to upload content later.
Part of #1732.