sliding_sync(state): use * for m.call.member when requesting state through sliding sync
#4166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanceriu
force-pushed
the
stefan/callMemberSentinel
branch
from
49f0342 to
8d0726c
Compare
…e through sliding sync - introduced in #4159 with an empty string - call members use custom `state_key`s and as such not specifying the sentinel won't match them and state won't be returned
stefanceriu
force-pushed
the
stefan/callMemberSentinel
branch
from
8d0726c to
bb55493
Compare
jmartinesp
approved these changes
Oct 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4166 +/- ##
==========================================
- Coverage 84.85% 84.82% -0.04%
==========================================
Files 269 269
Lines 28916 28916
==========================================
- Hits 24536 24527 -9
- Misses 4380 4389 +9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required_stateforRoomListService#4159 with an empty stringstate_keys and as such not specifying the sentinel won't match them and state won't be returned