refactor(event cache): a few AllEventsCache refactorings
#4471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pend_related_event`
…lEventsCache` No code changes.
Reduce indent, simplify parameter type, etc.
…wkward The last parameter was passed to handle recursivity: introduce a small `_rec` helper function, and call that instead, so external callers don't have to interact with the weird API.
… of `AllEventsCache`
jmartinesp
approved these changes
Jan 7, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4471 +/- ##
==========================================
- Coverage 85.07% 85.07% -0.01%
==========================================
Files 283 283
Lines 31775 31777 +2
==========================================
+ Hits 27033 27034 +1
- Misses 4742 4743 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was investigating a potential deadlock with the event cache storage, and only found a few places where to make the code a bit more idiomatic and more readable.
Should be reviewed commit by commit.