Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make experimental-sliding-sync compile on WASM #4474

Closed
wants to merge 1 commit into from

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Jan 7, 2025

Unfortunately the matrix_sdk::Client is not Send on WASM, which is probably not going to be easy to fix. Since PreviousEventsProvider is never used as a trait object, there should be no harm in relaxing its supertraits (on WASM).

I intentionally left out xtask::ci changes, because I think this should be tested as part of a matrix-sdk-ui WASM check down the line.

Signed-off-by: Jonas Platte jplatte+matrix@posteo.de

Unfortunately the matrix_sdk::Client is not Send on WASM, which is
probably not going to be easy to fix. Since PreviousEventsProvider is
never used as a trait object, there should be no harm in relaxing its
supertraits (on WASM).
@jplatte jplatte requested a review from a team as a code owner January 7, 2025 19:08
@jplatte jplatte requested review from poljar and removed request for a team January 7, 2025 19:08
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.08%. Comparing base (2ef14de) to head (616fbe9).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4474      +/-   ##
==========================================
- Coverage   85.09%   85.08%   -0.01%     
==========================================
  Files         283      283              
  Lines       31778    31778              
==========================================
- Hits        27041    27038       -3     
- Misses       4737     4740       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hywan
Copy link
Member

Hywan commented Jan 8, 2025

Thanks for the PR!

Closing in favor of #4483 as it contains a commit to remove SlidingSyncRoomInner::client (it's useless, booo dead code, booo).

@Hywan Hywan closed this Jan 8, 2025
@jplatte jplatte deleted the jplatte/wasm-sliding-sync branch January 8, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants