feat(timeline): allow sending mentions along with media #4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 8205da8 it has been possible to attach (intentional) mentions to _edited_ media captions, but the send_$mediatype() timeline APIs provided no way to send them with the initial event. This fixes that. Signed-off-by: Joe Groocock <me@frebib.net>
frebib
force-pushed
the
frebib/mention-media-caption
branch
from
d12ce97 to
595e8a4
Compare
|
Hey, it looks like you deleted the sign-off part of the PR template. Pretty sure that's required (see https://github.com/matrix-org/matrix-rust-sdk/blob/main/CONTRIBUTING.md#sign-off) |
|
My commit already contains a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4475 +/- ##
==========================================
- Coverage 85.09% 85.08% -0.01%
==========================================
Files 283 283
Lines 31778 31778
==========================================
- Hits 27041 27038 -3
- Misses 4737 4740 +3 ☔ View full report in Codecov by Sentry. |
bnjbvr
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 8205da8 it has been possible to attach (intentional) mentions to edited media captions, but the
send_${mediatype}()timeline APIs provided no way to send them with the initial event. This fixes that.If I missed something, or completely got the wrong end of the stick, feel free to decline this or point me in the right direction. I'm not familiar with Rust, but this at least compiles and doesn't crash EXA on my phone.