Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix incorrect debug_struct calls in several places #4488

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

andybalaam
Copy link
Member

No description provided.

@andybalaam andybalaam requested review from a team as code owners January 8, 2025 15:12
@andybalaam andybalaam requested review from poljar and removed request for a team January 8, 2025 15:12
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some missing ones?
impl fmt::Debug for LeftRoomUpdate {
I wonder if it is doing the right thing for PendingEdit or BuilderStoreConfig?

@poljar
Copy link
Contributor

poljar commented Jan 9, 2025

I think there are some missing ones? impl fmt::Debug for LeftRoomUpdate { I wonder if it is doing the right thing for PendingEdit or BuilderStoreConfig?

That one was done in #4487.

@poljar poljar enabled auto-merge (rebase) January 10, 2025 08:12
@poljar poljar merged commit 7ec384c into main Jan 10, 2025
40 checks passed
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.10%. Comparing base (dc2775e) to head (ec11658).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4488      +/-   ##
==========================================
- Coverage   85.11%   85.10%   -0.01%     
==========================================
  Files         283      283              
  Lines       31790    31790              
==========================================
- Hits        27059    27056       -3     
- Misses       4731     4734       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar poljar deleted the andybalaam/fix-incorrect-debug_struct branch January 10, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants