Fix new nightly warnings #4496
Merged
Fix new nightly warnings #4496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poljar
reviewed
Jan 9, 2025
jplatte
force-pushed
the
jplatte/nightly-warn
branch
from
6057b19 to
edfdbc2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4496 +/- ##
==========================================
+ Coverage 85.35% 85.36% +0.01%
==========================================
Files 284 284
Lines 31887 31885 -2
==========================================
+ Hits 27218 27220 +2
+ Misses 4669 4665 -4 ☔ View full report in Codecov by Sentry. |
bnjbvr
reviewed
Jan 13, 2025
| @@ -803,7 +803,7 @@ mod tests { | |||
| assert_items_eq!(linked_chunk, ['a', 'b', 'c'] ['d']); | |||
|
|
|||
| // Empty updates first. | |||
| let _ = linked_chunk.updates().take(); | |||
| let _ = linked_chunk.updates().unwrap().take(); | |||
There was a problem hiding this comment.
Thanks, that was indeed the expected behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jonas Platte jplatte+matrix@posteo.de