refactor(ui): Use RPITIT / AFIT for RoomDataProvider #4498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
approved these changes
Jan 10, 2025
|
Ah, I thought closing / re-opening would trigger CI but apparently there's now merge conflicts. |
jplatte
force-pushed
the
jplatte/room-data-provider-async-fn
branch
from
bc1422a to
914c344
Compare
jplatte
force-pushed
the
jplatte/room-data-provider-async-fn
branch
from
914c344 to
a4fb214
Compare
auto-merge was automatically disabled
January 10, 2025 21:07
Pull request was converted to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4497 (that one should be merged first).
I think this should be the last change required to make the UI crate compile on WASM. I'll make a separate PR to add that to CI afterwards.
Signed-off-by: Jonas Platte jplatte+matrix@posteo.de