fix: Implement visit_bytes for the Ed25519PublicKey deserialization #4499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poljar
requested review from
Hywan and
andybalaam
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4499 +/- ##
==========================================
- Coverage 85.37% 85.36% -0.01%
==========================================
Files 284 284
Lines 31885 31892 +7
==========================================
+ Hits 27222 27225 +3
- Misses 4663 4667 +4 ☔ View full report in Codecov by Sentry. |
Hywan
approved these changes
Jan 10, 2025
It's in #4500, though my commit has been squashed in there as well. |
andybalaam
approved these changes
Jan 10, 2025
This fixes the deserialization of the SenderData since it switched to the base64 encoding for serialization of the master key in one of its variants. The issue was introduced in 5ff556f.
poljar
force-pushed
the
poljar/fix-sender-data-deserialization
branch
from
ddd18d1 to
ba35b61
Compare
|
Thanks for the test @BillCarsonFr. |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the deserialization of the SenderData since it switched to the base64 encoding for serialization of the master key in one of its variants.
The issue was introduced in 5ff556f (#4450).