Conversation
…kio::spawn` to make it wasm compatible.
2ca6fd5 to
3e06868
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4959 +/- ##
==========================================
- Coverage 85.95% 85.93% -0.02%
==========================================
Files 325 325
Lines 35649 35649
==========================================
- Hits 30641 30636 -5
- Misses 5008 5013 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jplatte
reviewed
Apr 22, 2025
3e06868 to
f503739
Compare
jplatte
approved these changes
Apr 23, 2025
f503739 to
3560e7e
Compare
This makes it possible to use the widget driver with the wasm target. It allows us to use the `DropGuard`.
3560e7e to
ae83b6c
Compare
bnjbvr
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a revived version of: #4707 since it is now possible to easily add wasm support thanks to: #4572
Using the
executer::spawnwill selecttokio::spawnorwasm_bindgen_futures::spawn_localbased on what platform we are on.They behave differently in thattokioactually starts the async block inside the spawn but the wasmspawnwrapper will only start the part that is not inside theasyncblock and the join handle needs to be awaited for it to work.This has now changed with: #4572.
Now they behave the same and this PR becomes a very simple change.
Signed-off-by: