Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC4133: Extending User Profile API with Key:Value Pairs #4133

Merged
merged 57 commits into from
Jan 31, 2025

Conversation

tcpipuk
Copy link
Contributor

@tcpipuk tcpipuk commented Apr 19, 2024

@tcpipuk tcpipuk changed the title MSC0000: Extending User Profile API with Key:Value Pairs MSC4133: Extending User Profile API with Key:Value Pairs Apr 19, 2024
@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Apr 19, 2024
proposals/4133-extended-profiles.md Outdated Show resolved Hide resolved
proposals/4133-extended-profiles.md Outdated Show resolved Hide resolved
@turt2live
Copy link
Member

@tcpipuk when you get a chance, please sign off on your changes to allow the MSC to eventually be eligible for acceptance.

@tcpipuk

This comment was marked as resolved.

@turt2live
Copy link
Member

Looks great, thanks!

@tcpipuk tcpipuk marked this pull request as ready for review April 19, 2024 19:46
@andrewzhurov
Copy link

Seems we discuss here a key-value CRDT, as keys would need to be updated over time. Personally, I'm all in favor.
With no regard be those events a part of a (messaging) Room or be in its own Profile Room (#1769) (which would be neat),
we need a mechanism to get the latest key-value pairs.

Matrix Event Graph is isomorphic to Merkle-CRDT that powers OrbitDB (key-value DB is one of the supported CRDT).
Taking an inspiration from how key-value CRDT works may be of help to spec it for those Servers wishing to opt-in.

proposals/4133-extended-profiles.md Outdated Show resolved Hide resolved
proposals/4133-extended-profiles.md Outdated Show resolved Hide resolved
proposals/4133-extended-profiles.md Outdated Show resolved Hide resolved
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mscbot concern "the MSC does not provide an example for clients of when they should hide abusive custom profile fields within the context of a room"

proposals/4133-extended-profiles.md Outdated Show resolved Hide resolved
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@anoadragon453
Copy link
Member

@mscbot resolve "the MSC does not provide an example for clients of when they should hide abusive custom profile fields within the context of a room"

as the suggestion in #4133 (comment) was accepted.

(This is mostly symbolic - I don't think the bot actually picked up the concern during FCP.)

@mscbot

This comment was marked as resolved.

MTRNord

This comment was marked as duplicate.

proposals/4133-extended-profiles.md Show resolved Hide resolved
proposals/4133-extended-profiles.md Show resolved Hide resolved
proposals/4133-extended-profiles.md Show resolved Hide resolved
proposals/4133-extended-profiles.md Show resolved Hide resolved
@turt2live
Copy link
Member

The SCT would like to take recent comments into consideration as part of the FCP call for this MSC, and is pausing FCP for the moment while that consideration happens.

Our process is that a concern raised during FCP prevents the FCP from finishing, but our bot doesn't understand that and may say that the FCP is finished over the weekend. If this happens, it's untrue and we'll manually correct the state to be in FCP when we're back at a terminal.

@mscbot concern Feedback during FCP needs consideration.

@mscbot mscbot added the unresolved-concerns This proposal has at least one outstanding concern label Jan 23, 2025
@mscbot

This comment was marked as outdated.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jan 25, 2025
@richvdh
Copy link
Member

richvdh commented Jan 25, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

No it isn't

@richvdh richvdh added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. disposition-merge and removed finished-final-comment-period labels Jan 25, 2025
@turt2live
Copy link
Member

I'm not sure how the bot will respond to this, but the SCT is resolving the outstanding concern on addressing the recent feedback. Under normal process, this would cause FCP to finish immediately, however it feels valuable for this MSC to have an opportunity for final thoughts to be raised.

FCP will resume until 15:00 UTC on Friday, January 31st, 2025.

@mscbot resolve Feedback during FCP needs consideration.

@mscbot mscbot removed the unresolved-concerns This proposal has at least one outstanding concern label Jan 30, 2025
@turt2live
Copy link
Member

The final comment period, with a disposition to merge, as per the review above, is now complete.

No it isn't

Now it is

@turt2live turt2live added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jan 31, 2025
@turt2live turt2live merged commit eb813af into matrix-org:main Jan 31, 2025
1 check passed
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec
Projects
Status: Requires spec writing
Development

Successfully merging this pull request may close these issues.