-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC4133: Extending User Profile API with Key:Value Pairs #4133
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Looks great, thanks! |
Seems we discuss here a key-value CRDT, as keys would need to be updated over time. Personally, I'm all in favor. Matrix Event Graph is isomorphic to Merkle-CRDT that powers OrbitDB (key-value DB is one of the supported CRDT). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mscbot concern "the MSC does not provide an example for clients of when they should hide abusive custom profile fields within the context of a room"
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@mscbot resolve "the MSC does not provide an example for clients of when they should hide abusive custom profile fields within the context of a room" as the suggestion in #4133 (comment) was accepted. (This is mostly symbolic - I don't think the bot actually picked up the concern during FCP.) |
This comment was marked as resolved.
This comment was marked as resolved.
The SCT would like to take recent comments into consideration as part of the FCP call for this MSC, and is pausing FCP for the moment while that consideration happens. Our process is that a concern raised during FCP prevents the FCP from finishing, but our bot doesn't understand that and may say that the FCP is finished over the weekend. If this happens, it's untrue and we'll manually correct the state to be in FCP when we're back at a terminal. @mscbot concern Feedback during FCP needs consideration. |
This comment was marked as outdated.
This comment was marked as outdated.
|
I'm not sure how the bot will respond to this, but the SCT is resolving the outstanding concern on addressing the recent feedback. Under normal process, this would cause FCP to finish immediately, however it feels valuable for this MSC to have an opportunity for final thoughts to be raised. FCP will resume until 15:00 UTC on Friday, January 31st, 2025. @mscbot resolve Feedback during FCP needs consideration. |
|
Rendered
Signed-off-by: Tom Foster tom@tcpip.uk
Known Implementations:
FCP tickyboxes
MSC checklist