Skip to content

Commit

Permalink
Remove trailing slash on void HTML elements (#2009)
Browse files Browse the repository at this point in the history
According to the W3C's HTML validator, trailing slashes in void-element have no effect,
and might interact badly in some cases.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
  • Loading branch information
zecakeh authored Nov 20, 2024
1 parent 69e162e commit c16788f
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 11 deletions.
1 change: 1 addition & 0 deletions changelogs/internal/newsfragments/2009.clarification
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove trailing slash on void HTML elements.
2 changes: 1 addition & 1 deletion layouts/partials/events/render-event.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ <h1 id="{{ anchorize $event_name }}">

</summary>

<hr/>
<hr>

{{ if (index $event_data "x-addedInMatrixVersion") }}
{{ partial "added-in" (dict "v" (index $event_data "x-addedInMatrixVersion")) }}
Expand Down
4 changes: 2 additions & 2 deletions layouts/partials/favicons.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
{{- $ico := resources.Get "icons/favicon.ico" -}}
{{- $svg := resources.Get "icons/favicon.svg" -}}

<link rel="shortcut icon" href="{{ $ico.RelPermalink }}" >
<link rel="icon" type="image/svg+xml" href="{{ $svg.RelPermalink }}" />
<link rel="shortcut icon" href="{{ $ico.RelPermalink }}">
<link rel="icon" type="image/svg+xml" href="{{ $svg.RelPermalink }}">
6 changes: 3 additions & 3 deletions layouts/partials/openapi/render-operation.html
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ <h1 id="{{ $anchor }}">
</h1>
</summary>

<hr/>
<hr>

{{ if $operation_data.deprecated }}
{{ partial "alert" (dict "type" "warning" "omit_title" "true" "content" "This API is deprecated and will be removed from a future release.") }}
Expand Down Expand Up @@ -84,9 +84,9 @@ <h1 id="{{ $anchor }}">
</tr>
</table>

<hr/>
<hr>
{{ partial "openapi/render-request" (dict "parameters" $operation_data.parameters "request_body" $operation_data.requestBody "anchor_base" $anchor ) }}
<hr/>
<hr>
{{ partial "openapi/render-responses" (dict "responses" $operation_data.responses "anchor_base" $anchor ) }}

</details>
Expand Down
2 changes: 1 addition & 1 deletion layouts/shortcodes/changelog/changelogs.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
*/}}

{{ with index .Page.RegularPages.ByDate.Reverse 0 }}
<meta http-equiv="refresh" content="0; url={{ .RelPermalink }}" />
<meta http-equiv="refresh" content="0; url={{ .RelPermalink }}">
{{ end }}
2 changes: 1 addition & 1 deletion layouts/shortcodes/definition.html
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ <h1>

</summary>

<hr/>
<hr>

{{ if (index $definition "x-addedInMatrixVersion") }}
{{ partial "added-in" (dict "v" (index $definition "x-addedInMatrixVersion")) }}
Expand Down
4 changes: 2 additions & 2 deletions layouts/shortcodes/diagram.html
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@
{{- $fallback := $highRes.Resize (printf "%sx png" $width) -}}

<picture>
<source srcset="{{ $lowRes.RelPermalink }}, {{ $highRes.RelPermalink }} 2x" type="image/webp" />
<img src="{{ $fallback.RelPermalink }}" alt="{{ $alt }}" width="{{ $width }}" height="{{ $height }}" loading="lazy" />
<source srcset="{{ $lowRes.RelPermalink }}, {{ $highRes.RelPermalink }} 2x" type="image/webp">
<img src="{{ $fallback.RelPermalink }}" alt="{{ $alt }}" width="{{ $width }}" height="{{ $height }}" loading="lazy">
</picture>
{{- else -}}
{{- errorf "diagram %s not found" $path -}}
Expand Down
2 changes: 1 addition & 1 deletion layouts/shortcodes/event-fields.html
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ <h1>
</h1>
</summary>

<hr/>
<hr>

{{ $event.description | markdownify }}

Expand Down

0 comments on commit c16788f

Please sign in to comment.