Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strike element is deprecated, s replaces it #1629

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

cloudrac3r
Copy link
Contributor

@cloudrac3r cloudrac3r commented Aug 30, 2023

Pull Request Checklist

Description

The strike element is deprecated in the HTML spec. Clients should prefer s instead if they wish to mark text with strikethrough without semantic meaning.

As far as I am aware, no client actually supports sending messages with strikethrough formatting, so this shouldn't affect current compatibility.

I hope I filled out this PR template correctly :)

Signed-off-by: Cadence Ember cadence@disroot.org

Preview: https://pr1629--matrix-spec-previews.netlify.app

@cloudrac3r cloudrac3r requested a review from a team as a code owner August 30, 2023 01:51
@KitsuneRal
Copy link
Member

Well, in fact, a few clients support sending raw HTML (I just checked Quaternion and Element Web for a very quick check), and although Quaternion still converts <strike> to <del> even when sent as raw HTML, Element Web doesn't do that and faithfully sends <strike> to the homeserver. I'm afraid this would require a (very simple) MSC therefore.

@MTRNord
Copy link
Contributor

MTRNord commented Aug 30, 2023

I think the current state is more confusing considering the syntax ele Web input for example uses is <del> and not any of the others.

@KitsuneRal
Copy link
Member

Well it's the same old HTML story - <strong> vs. <b> etc. <del> is in the recommended list of tags just as well; even though the tags are sort-of similar semantically, replacing <strike> with <s> is orthogonal to having <del> around.

@anoadragon453
Copy link
Member

@cloudrac3r As @KitsuneRal mentioned, this change would require a (small) Matrix Spec Change to carry out. See this documentation for the process. Would you be willing to write one up?

I also wonder if it would be better to instead add s alongside strike, mark strike as deprecated and then eventually remove it sometime in the future?

@richvdh
Copy link
Member

richvdh commented Sep 19, 2023

Closing this for now. As others have noted, we'll need an MSC.

@richvdh richvdh closed this Sep 19, 2023
@cloudrac3r
Copy link
Contributor Author

@richvdh @anoadragon453 MSC4077 has landed, so this spec change is good to go. Can you reopen?

This will fix #1492.

@anoadragon453 anoadragon453 reopened this Feb 26, 2024
@anoadragon453
Copy link
Member

Re-opening as per @cloudrac3r's request.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@turt2live turt2live merged commit e2dc5a3 into matrix-org:main Feb 26, 2024
12 checks passed
@cloudrac3r cloudrac3r deleted the replace-strike-with-s branch February 26, 2024 23:17
KitsuneRal added a commit to quotient-im/Quaternion that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants