-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note that /logout doesn't take a body #1644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm, this makes me sad.
I want to claim that this is misleading wording on behalf of the /logout
endpoint definition, and a misfeature in complement/synapse/dendrite, rather than an indication that the body should actually allowed to be empty. Granting /logout
an exception in this way very much puts it in a class of one.
On the other hand, it's clearly been this way since forever, and Element-Web relies upon it. So I guess I have to suck up the fact that there's an exception and make it something to fix for OIDC.
Anyway, /logout/all
has the same problem I think.
(we should file a 'Wart' issue against the spec for this) |
@reivilibre would you be able to update this? |
Issue created at #1845 but I don't have the ability to add a Wart label |
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/logout
says it does not take a request body1, so add it to the list of exceptions at the top.I note that Complement does not send a request body for this endpoint, so that must mean Synapse and Dendrite allow that.
Preview: https://pr1644--matrix-spec-previews.netlify.app
Footnotes
https://spec.matrix.org/v1.8/client-server-api/#post_matrixclientv3logout ↩