-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo in "Event annotations" module #1658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting that!
One small thing: can you add a newsfragment please? |
no clue what you mean by this, so no, sorry |
https://github.com/matrix-org/matrix-spec/blob/main/CONTRIBUTING.rst#adding-to-the-changelog |
applied |
@@ -0,0 +1 @@ | |||
event_annotations: annotion => annotation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually for this sort of thing we normally just use
event_annotations: annotion => annotation | |
Fix various typos throughout the specification. |
(See https://spec.matrix.org/v1.8/changelog/#client-server-api for example)
applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It's fine for this trivial PR, but for future reference, please don't force-push after a review - it makes it very hard to see what has changed.
Preview: https://pr1658--matrix-spec-previews.netlify.app