Mention notifying AS for sender_localpart events #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kladki
force-pushed
the
sender_localpart-send-events
branch
from
767984d to
48e6b30
Compare
richvdh
reviewed
Apr 30, 2024
|
Actually yours makes more sense if we are keeping my original change in, so let's go with that. I'll update the PR when I get home. 👍
30 Apr 2024 19:09:46 Richard van der Hoff ***@***.***>:
…
***@***.**** commented on this pull request.
----------------------------------------
In data/api/application-service/definitions/registration.yaml[#1810 (comment)]:
> + description: |-
+ The localpart of the user associated with the application service. Events will be sent to the AS if this user is the target of the event, or
+ is a joined member of the room where the event occurred.
Ok so if I understand correctly you want to do your change in addition to the one that is already in this pull request, right?
Yes, right.
If so do you think it would be better to switch out your suggestion with my first reply[#1810 (comment)], while still keeping my initial change (contents of this PR)?
Oh right. Er well, not really? But I don't feel that strongly about it. It would probably be easier if you just made a change and we can see how it looks, before discussing further.
—
Reply to this email directly, view it on GitHub[#1810 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/BFX23U35BTCAFSZ7DVI2YETY77M6TAVCNFSM6AAAAABG3LJIWCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMZSGE2TONZTGA].
You are receiving this because you authored the thread.
[Tracking image][https://github.com/notifications/beacon/BFX23U35ZAUBUZKRC23YXCLY77M6TA5CNFSM6AAAAABG3LJIWCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTZEBCCE.gif]
Message ID: ***@***.***>
|
Kladki
force-pushed
the
sender_localpart-send-events
branch
from
48e6b30 to
61d7c94
Compare
Signed-off-by: Matthias Ahouansou <matthias@ahouansou.cz>
Kladki
force-pushed
the
sender_localpart-send-events
branch
from
61d7c94 to
6d8a67c
Compare
richvdh
approved these changes
May 1, 2024
There was a problem hiding this comment.
Thanks!
By the way, for future reference: please avoid force-pushing after a review has been done. It's fine in this case, but when it's part of a larger PR, it becomes very hard to see what has changed between the initial review and a force-push. We'll squash all the changes into a single commit when we merge the PR.
|
On the subject of the change itself, @turt2live said:
So I think we're agreed this doesn't need an MSC |
53 tasks
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conduit and Synapse already do this, and appservices such as Draupnir depend on this behavior.
Preview: https://pr1810--matrix-spec-previews.netlify.app