Clarify that room ACLs apply to EDUs #1833
Conversation
Signed-off-by: Matthias Ahouansou <matthias@ahouansou.cz>
| @@ -1212,7 +1212,7 @@ of `M_FORBIDDEN`. | |||
|
|
|||
| The following endpoint prefixes MUST be protected: | |||
|
|
|||
| - `/_matrix/federation/v1/send` (on a per-PDU basis) | |||
| - `/_matrix/federation/v1/send` (on a per-PDU and EDU basis) | |||
There was a problem hiding this comment.
I don't see this in the original MSC1383 nor any evidence that Synapse has historically done this.
It probably makes sense, but might need an MSC.
I'd be interested in the opinion of those around when ACLs were added, however.
There was a problem hiding this comment.
I assumed that this would have been the intention of the original MSC, but I didn't know where to look to find historical MSCs.
I'm not sure when that MSC was written however, and if that came before or after (typing and/or read-receipt) EDUs were added.
There was a problem hiding this comment.
Since the MSC doesn't say EDUs are forbidden and Synapse doesn't reject incoming EDUs, I don't think it can be added to the spec without a MSC
There was a problem hiding this comment.
Typing and read-receipts certainly existed before server ACLs, and yes, this would probably make sense, but unfortunately it's not what the MSC says, and not what the Synapse implementation does (indeed, there is an open issue about it: element-hq/synapse#11456).
This seems like a great idea but we'd need an MSC before we can add it to the spec. Please do open one! But I'm going to have to close this for now.
There was a problem hiding this comment.
Please do open one!
I plan to do so in the coming weeks. 👍
Pull Request Checklist
Preview: https://pr1833--matrix-spec-previews.netlify.app