Add missing error.soft_logout #1836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaarthShah
force-pushed
the
error-soft-logout
branch
2 times, most recently
from
8246b3b to
6d1a4e8
Compare
PaarthShah
force-pushed
the
error-soft-logout
branch
from
6d1a4e8 to
8a87caf
Compare
Signed-off-by: Paarth Shah <mail@shahpaarth.com>
PaarthShah
force-pushed
the
error-soft-logout
branch
from
8a87caf to
d0f3719
Compare
richvdh
requested changes
Jun 11, 2024
There was a problem hiding this comment.
Two things:
- This change adds
soft_logoutevery single error response in the spec, including the federation API (which obviously doesn't support soft-logout), 429 responses, 404 responses. In short, to lots of places it doesn't apply at all. I'd suggest defining a new type (unknown_token_error.yamlor something) which is only used in 401 responses. - Please can you link to the section on soft logout (https://pr1836--matrix-spec-previews.netlify.app/client-server-api/#soft-logout).
|
Thanks for your contribution. I'm going to close this for now as the changes requested haven't been made. If you're interested in continuing to work on this please let us know and we can reopen the pull request. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
soft_logoutis used by 401 responses by the refresh endpoint, but is not defined properly on the error.matrix-spec/data/api/client-server/refresh.yaml
Line 100 in a175506
Pull Request Checklist
Preview: https://pr1836--matrix-spec-previews.netlify.app