Remove withVersioning parameter of rver-fragment shortcode.
#1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now detect automatically in the `added-in` and `changed-in` shortcodes whether we need to add text according to the page's room version so this parameter has become unnecessary. Moreover, forgetting to set this param can remove the text generated by the shortcodes so it is safer to just get rid of it. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1884, we detect automatically in the
added-inandchanged-inshortcodes whether we need to add text according to the page's room version so this parameter has become unnecessary.Moreover, forgetting to set this param can remove the text generated by the shortcodes so it is safer to just get rid of it.
Case in point, two
[New in this version]were missing:Pull Request Checklist
Preview: https://pr1971--matrix-spec-previews.netlify.app