Rename Client Config to Account Data #2032
Conversation
There was a problem hiding this comment.
I assume this is related to #2030.
Thank you for the contribution. It's a fair start, but - even though I said "don't try to solve everything at once" - I think this is the opposite extreme. Just changing the list of modules, without actually changing the name of the section itself, is going to cause confusion. Perhaps you could update your PR so that you're also changing the name of the section itself.
A couple of other points to note:
- It's helpful to give a bit of description in the PR title about what the PR is trying to achieve. "Update _index.md" doesn't really tell anyone anything.
- You've ticked "Pull request includes a sign off", but your pull request does not, in fact, include a sign off.
Signed-off-by: Ved Prasad Bankeshwar ved.bankeshwar@gmail.com
yoyodragon
changed the title
yoyodragon
changed the title
|
Thank you for the suggestions, I have tried implementing them to the best of my knowledge. |
richvdh
changed the title
1. Added a changelog entry 2. Modify URL fragment 3. restore accidental change in changelog entries
changing the URL fragments in a few missed spaces
There was a problem hiding this comment.
This looks good to me now. However, the pull request still does not include a sign off.
Please read https://github.com/matrix-org/matrix-spec/blob/main/CONTRIBUTING.rst#sign-off again. In particular, note that it says:
If you agree to this for your contribution, then all that's needed is to include the line in ... [a] pull request comment:
Signed-off-by: Your Name <your@email.example.org>
Part of issue #2030.
Pull Request Checklist
Preview: https://pr2032--matrix-spec-previews.netlify.app