Fix syntax highlighting and click-to-copy buttons for code blocks#2049
Merged
anoadragon453 merged 4 commits intomatrix-org:mainfrom Jan 14, 2025
Merged
Fix syntax highlighting and click-to-copy buttons for code blocks#2049anoadragon453 merged 4 commits intomatrix-org:mainfrom
anoadragon453 merged 4 commits intomatrix-org:mainfrom
Conversation
It turns out that we were purging too much CSS which broke their style. We use a simple but lazy solution that parses the JS scripts and keeps the matching selectors. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
zecakeh
changed the title
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
anoadragon453
approved these changes
Jan 14, 2025
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
Improvement is clear - thanks for catching and fixing!
30 tasks
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that we were purging too much CSS since #2008 which broke their style.
We use a simple but lazy solution that parses the JS scripts and keeps the matching selectors. This increases the CSS file size to 59KB.
Before:
After:
Pull Request Checklist
Preview: https://pr2049--matrix-spec-previews.netlify.app