Skip to content

Replace Hugo shortcodes in OpenAPI output #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 8, 2025

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Feb 25, 2025

I went with simple prefix replacements, but for the boxes shortcodes, it might not be obvious where the note/rationale/warning ends if it spans several paragraphs. We might want to use blockquotes too.

Fixes #1873.

Pull Request Checklist

Preview: https://pr2088--matrix-spec-previews.netlify.app

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner February 25, 2025 17:29
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh
Copy link
Contributor Author

zecakeh commented Feb 25, 2025

This also updates the Python version used in CI because match was added in Python 3.10.

zecakeh added 4 commits May 6, 2025 10:52
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from richvdh May 6, 2025 10:14
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richvdh richvdh enabled auto-merge (squash) May 8, 2025 09:28
@richvdh richvdh merged commit fe46e0c into matrix-org:main May 8, 2025
12 checks passed
@zecakeh zecakeh deleted the openapi-shortcodes branch May 8, 2025 09:46
Johennes pushed a commit to Johennes/matrix-spec that referenced this pull request May 30, 2025
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handlebars spills through into API viewer
2 participants