add note about why dns resolution order is necessary

matrix-org · Nov 14, 2023 · c5f0366 · c5f0366
1 parent 6463118
commit c5f0366
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/test/appservice/integration/provisionTest.ts b/test/appservice/integration/provisionTest.ts
@@ -10,6 +10,7 @@ interface Context extends Mocha.Context {
     appservice?:  MjolnirAppService
 }
 
+// Necessary for CI: Node 17+ defaults to using ipv6 first, but Github Actions does not support ipv6
 dns.setDefaultResultOrder('ipv4first');
 
 describe("Test that the app service can provision a mjolnir on invite of the appservice bot", function () {

diff --git a/test/appservice/integration/webAPITest.ts b/test/appservice/integration/webAPITest.ts
@@ -13,6 +13,7 @@ interface Context extends Mocha.Context {
     moderator?: MatrixClient
 }
 
+// Necessary for CI: Node 17+ defaults to using ipv6 first, but Github Actions does not support ipv6
 dns.setDefaultResultOrder('ipv4first');
 
 describe("Test that the app service can provision a mjolnir when requested from the web API", function () {

diff --git a/test/integration/fixtures.ts b/test/integration/fixtures.ts
@@ -3,6 +3,7 @@ import { makeMjolnir, teardownManagementRoom } from "./mjolnirSetupUtils";
 import { register } from "prom-client";
 import dns from 'node:dns';
 
+// Necessary for CI: Node 17+ defaults to using ipv6 first, but Github Actions does not support ipv6
 dns.setDefaultResultOrder('ipv4first');
 
 // When Mjolnir starts (src/index.ts) it clobbers the config by resolving the management room