-
Notifications
You must be signed in to change notification settings - Fork 60
Add some releasing instructions #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# Releasing mjolnir | ||
|
||
1. Create a new branch and edit the `version` variable of `package.json` to reflect the new version | ||
2. Once that branch has been merged, switch back to the main branch and pull in the new changes | ||
3. Tag the new version, ie `git tag -s vX.Y.Z` (where vX.Y.Z is the new version), and push the tag | ||
4. Once the tag has been pushed, draft a new release on github: https://github.com/matrix-org/mjolnir/releases/new, | ||
using the Generate release notes button to automatically create the release notes/changelog | ||
5. Double-check that everything is correct and make any changes as necessary, then publish the release | ||
6. Publishing the release should kick off a Github Action to build and push the release to Dockerhub - | ||
verify that this did occur successfully | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@H-Shay There should be a Mjolnir wiki within the Element wiki (if such a thing still exists), I'm not sure why these were never transferred to this repository but there were instructions for how to release Mjolnir there that are still accurate. Mjolnir was released with the
yarn version
script to ensure that theversion
in package.json, the version within the synapse module, and the git tag are all synchronised without causing a mistake from typos (this has happened previously). There were also instructions for how to push the release commit and the tag atomically so that someone new wouldn't push only one or the other.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the insight! I've found the entry.