Skip to content

output vector distance directly by Reader #23136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 27, 2025
Merged

output vector distance directly by Reader #23136

merged 10 commits into from
Nov 27, 2025

Conversation

@aunjgr
Copy link
Contributor

@aunjgr aunjgr commented Nov 24, 2025 •
edited
Loading

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #22508

What this PR does / why we need it:

  • avoid unnecessary copy of the big bulk of vectors
  • apply ORDER BY+LIMIT logic to memtable
  • refine EXPLAIN result

@aunjgr aunjgr requested a review from ouyuanning as a code owner November 24, 2025 09:08
@matrix-meow matrix-meow added the size/M Denotes a PR that changes [100,499] lines label Nov 24, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 27, 2025 •
edited
Loading

Merge Queue Status Beta

✅ The pull request has been merged

This pull request spent 9 seconds in the queue, with no time waiting for CI.
The checks were run in-place.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Compose CI / multi cn e2e bvt test docker compose(PESSIMISTIC)
    • check-neutral = Matrixone Compose CI / multi cn e2e bvt test docker compose(PESSIMISTIC)
    • check-skipped = Matrixone Compose CI / multi cn e2e bvt test docker compose(PESSIMISTIC)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Standlone CI / Multi-CN e2e BVT Test on Linux/x64(LAUNCH, PROXY)
    • check-neutral = Matrixone Standlone CI / Multi-CN e2e BVT Test on Linux/x64(LAUNCH, PROXY)
    • check-skipped = Matrixone Standlone CI / Multi-CN e2e BVT Test on Linux/x64(LAUNCH, PROXY)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
    • check-neutral = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
    • check-skipped = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone CI / SCA Test on Ubuntu/x86
    • check-neutral = Matrixone CI / SCA Test on Ubuntu/x86
    • check-skipped = Matrixone CI / SCA Test on Ubuntu/x86
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone CI / UT Test on Ubuntu/x86
    • check-neutral = Matrixone CI / UT Test on Ubuntu/x86
    • check-skipped = Matrixone CI / UT Test on Ubuntu/x86
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Compose CI / multi cn e2e bvt test docker compose(Optimistic/PUSH)
    • check-neutral = Matrixone Compose CI / multi cn e2e bvt test docker compose(Optimistic/PUSH)
    • check-skipped = Matrixone Compose CI / multi cn e2e bvt test docker compose(Optimistic/PUSH)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH,Optimistic)
    • check-neutral = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH,Optimistic)
    • check-skipped = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH,Optimistic)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Upgrade CI / Compatibility Test With Target on Linux/x64(LAUNCH)
    • check-neutral = Matrixone Upgrade CI / Compatibility Test With Target on Linux/x64(LAUNCH)
    • check-skipped = Matrixone Upgrade CI / Compatibility Test With Target on Linux/x64(LAUNCH)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Utils CI / Coverage
    • check-neutral = Matrixone Utils CI / Coverage
    • check-skipped = Matrixone Utils CI / Coverage

@mergify mergify bot added the queued label Nov 27, 2025
@mergify mergify bot merged commit 06493c2 into matrixorigin:main Nov 27, 2025
33 of 34 checks passed
@mergify mergify bot removed the queued label Nov 27, 2025
@aunjgr aunjgr deleted the no_copy_vec branch November 27, 2025 13:33
aunjgr added a commit to aunjgr/matrixone that referenced this pull request Nov 27, 2025
@aunjgr
output vector distance directly by Reader (matrixorigin#23136)
7b1c378 
- avoid unnecessary copy of the big bulk of vectors
- apply ORDER BY+LIMIT logic to memtable
- refine EXPLAIN result

Approved by: @ouyuanning, @heni02, @LeftHandCold, @cpegeric, @XuPeng-SH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpegeric cpegeric cpegeric approved these changes

@LeftHandCold LeftHandCold LeftHandCold approved these changes

@XuPeng-SH XuPeng-SH XuPeng-SH approved these changes

@ouyuanning ouyuanning ouyuanning approved these changes

@heni02 heni02 heni02 approved these changes

Assignees

No one assigned

Labels

kind/enhancement size/M Denotes a PR that changes [100,499] lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aunjgr @cpegeric @LeftHandCold @XuPeng-SH @ouyuanning @heni02 @matrix-meow