Open
Conversation
|
|
This reverts commit 675d6ca.
gouhongshen
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #20022
What this PR does / why we need it:
Problem
Under long-running load with proxy connection cache enabled, backend sessions (especially dump) kept accumulating, eventually causing login failures and instability.
Root Cause
QUIT handling was asynchronous (fire-and-forget), so cleanup was not guaranteed before the handler exited.
In handler defer logic, when connection cache was enabled, backend connections could be left open even if they were not successfully cached.
On EOF/connection-end paths (client disconnect without COM_QUIT), there was no explicit fallback cleanup.
Together, these paths leaked backend connections over time.
Fix
Make quit cleanup synchronous and idempotent in clientConn using sync.Once.
Track whether a backend connection was actually cached (cached flag).
In handler finalization:
keep backend connection only if it was successfully cached;
otherwise force cleanup via Quit() (fallback to Close()).
Add EOF/conn-end fallback cleanup by explicitly triggering the quit path once.
Why this is minimal
Changes are limited to proxy connection lifecycle/cleanup paths.
No changes to SQL execution, routing policy, or auth semantics.
Validation
Environment: local 2 CN + proxy, conn-cache enabled.
Workload: point_select_10_1000000_prepare, 300 terminals, 70 minutes.
Result: ERROR=0, SUCCEED.
dump connections stabilized (no continuous growth after warm-up), including past the previous ~57-minute failure window.
Repeated login checks succeeded; no panic observed.