Simple @CollectionConverterClass as suggested in #206#248
Open
PreXident wants to merge 2 commits intomatteobaccan:masterfrom
Open
Simple @CollectionConverterClass as suggested in #206#248PreXident wants to merge 2 commits intomatteobaccan:masterfrom
PreXident wants to merge 2 commits intomatteobaccan:masterfrom
Conversation
lviggiano
force-pushed
the
master
branch
2 times, most recently
from
1b8f02f to
cd3dc86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I have prepared a simple implementation of @CollectionConverterClass as suggested in #206.
In the project I work on, we needed something like CachingSetConverter for performance reasons and I hope this is a nice addition to the library.
This commit also contains some tests and documentation update. Please feel free to comment what to improve, I may have done something wrong as this is my first pull request :-D