Update MIGRATION_GUIDE_08.md #1393
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace factoryReset and destroy with erase and delete
|
Review changes with |
pullapprove
bot
requested review from
Apollon77,
lauckhart,
turon,
vves and
woody-apple
Apollon77
reviewed
Nov 13, 2024
| - **`factoryReset()`**: This factory resets the device. If started it is stopped and restarted afterward. | ||
| - **`destroy()`**: This destroys the node, taking it offline and removing it from the environment workers- | ||
| - **`erase()`**: This factory resets the device. If started it is stopped and restarted afterward. | ||
| - **`delete()`**: This destroys the node, taking it offline and removing it from the environment workers- |
Collaborator
There was a problem hiding this comment.
should this not be "cancel"?
Contributor
Author
There was a problem hiding this comment.
there is a third method called cancel(). it's already in the docs.
cancel leaves the structure intact according to the docs.
Collaborator
There was a problem hiding this comment.
Ahh ok I got confused.
delete is "Erase all persisted data and destroy the node." ... so it does erase() and then close()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace factoryReset and destroy with erase and delete