Conversation
Adding the new Mounted Dimmable load device type
|
Normally we auto generate this with the script |
I've posted it in the SDK repo. It was an oversight on their part.
I auto generate it this with the script from master branch: |
Hm, I see the generated output from current master generates like this: class MountedOnOffControl(DeviceType, device_type=0x010F):
"""Mounted On/Off Control."""
clusters = {
all_clusters.Groups,
all_clusters.Identify,
all_clusters.LevelControl,
all_clusters.OnOff,
all_clusters.ScenesManagement,
}
class MountedDimmableLoadControl(DeviceType, device_type=0x0110):
"""Mounted Dimmable Load Control."""
clusters = {
all_clusters.Groups,
all_clusters.Identify,
all_clusters.LevelControl,
all_clusters.OnOff,
all_clusters.ScenesManagement,
}So it is missing these base device type clusters too 🤷 I remember that source XML was always buggy, unfortunately. Since I don't think the clusters have real-world impact right now, I am fine adding those as is (since that is how the XML looks like currently too), and then later on fix the upstream XML. What do you think @marcelveldt . |
@lboue nice! That said, our script uses master branch anyways, see https://github.com/home-assistant-libs/python-matter-server/blob/main/scripts/generate_devices.py#L12-L13 😅 In the end, I don't think it is important to have v1.4-branch updated, that XML is not well maintained anyways. IMHO, more important would be to have it correct in master branch. As for the mounted device types, the base device types and the occupancy sensing are definitly missing. When you look at On/Off light, the optional clusters are there. So this actually needs some updates upstream as well. |
agners
left a comment
There was a problem hiding this comment.
Since this is the current state of the device types XML, let's just go with this.
Adding the new mounted device types (1.4).
Testing