-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make VM produce system logs #600
base: main
Are you sure you want to change the base?
Conversation
FYI diff for TLDR enabled system log checks, disabled some other checks (timestamp, DA validator), support foundry for impersonated bootloaders |
730b68c
to
08f584b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, and I like the changes a lot.
I would love to see seal criteria to avoid performance penalty; otherwice I'd say it's super mergeable.
What 💻
Major changes introduced in this PR:
Overall changes in this PR are a bit controversial as they introduce more of the upstream complexity into a testing tool. OTOH, I tried to contain the changes to L1-specific stuff and indeed the existing user flow is mostly unaffected (except for system log production, which arguably should have been enabled all this time). In other words protocol upgrade tx is not submitted when not running L1 and extra batch metadata is not used anywhere other than L1-L2 communication.
Related to #536
Why ✋
Major stepping stone toward working L2->L1 messages. I have a test working locally that is based on top of this branch.