Skip to content

Commit

Permalink
chore(ci): Fix release-please workflows (#25)
Browse files Browse the repository at this point in the history
- Fix echoing outputs
- Fix extracting version (PR title is not available on `push` trigger,
so I'm reading manifest -- it's also safer).
  • Loading branch information
popzxc authored Sep 3, 2024
1 parent 24ff829 commit 1529c47
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/release-please-prepare-branch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,9 @@ jobs:
- name: Install cargo-workspaces
run: cargo install cargo-workspaces

- name: Extract version from PR title
id: extract_version
run: |
NEW_VERSION=$(echo "${{ github.event.pull_request.title }}" | grep -oP 'v\d+\.\d+\.\d+')
echo "version=$NEW_VERSION" >> "$GITHUB_ENV"
- name: Bump version
run: |
NEW_VERSION=$(cat .github/release-please/manifest.json | jq '."."')
cargo ws version custom $NEW_VERSION --yes --no-git-commit --exact
- name: Push changes
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
manifest-file: .github/release-please/manifest.json

- name: Show outputs
run: echo "${{ toJSON(steps.release.outputs) }}"
run: echo "${{ join(steps.release.outputs.*, '\n') }}"

process-release:
runs-on: [ubuntu-22.04-github-hosted-32core]
Expand Down

0 comments on commit 1529c47

Please sign in to comment.