chore: Warnings & obsolete code removal (#122)

* Cleaned up warnings
* Removed obsolete code (binaries and files that are no longer used)
* Fixed 2 cases, where we should be using u8_iter()

crates/zkEVM-assembly/src/assembly/parse/addressing.rs

@@ -369,7 +369,7 @@ fn parse_brackets_content<'a>(input: &'a str) -> IResult<&'a str, &'a str> {
 
 pub(crate) fn parse_absolute_addressing_single<'a>(
     input: &'a str,
-) -> IResult<&str, (RegisterOperand, u64)> {
+) -> IResult<&'a str, (RegisterOperand, u64)> {
     // we want either rX +/- imm
 
     // so we want may be space | may be rX | may be space | may be + or - | may be space | may be immediate
@@ -541,12 +541,12 @@ pub(crate) fn parse_arith_separated<'a>(
     Ok(("", results))
 }
 
-fn parse_immediate<'a>(input: &'a str) -> IResult<&str, u64> {
+fn parse_immediate<'a>(input: &'a str) -> IResult<&'a str, u64> {
     let (rest, _) = nom::bytes::complete::tag::<_, _, nom::error::Error<_>>("#")(input)?;
     parse_immediate_value(rest)
 }
 
-fn parse_immediate_value<'a>(input: &'a str) -> IResult<&str, u64> {
+fn parse_immediate_value<'a>(input: &'a str) -> IResult<&'a str, u64> {
     let rest = input;
     let mut hex_parser = nom::sequence::tuple::<_, _, nom::error::Error<_>, _>((
         all_from_tag_until_1_noconsume(

crates/zkEVM-assembly/src/assembly/parse/constant_operand.rs

@@ -7,7 +7,7 @@ use crate::assembly::mnemonic::all_until1_include_terminator;
 
 use crate::assembly::operand::ConstantOperand;
 
-pub(crate) fn parse_constant_operand<'a>(input: &'a str) -> IResult<&str, FullOperand> {
+pub(crate) fn parse_constant_operand<'a>(input: &'a str) -> IResult<&'a str, FullOperand> {
     // we try to parse something like @label[reg + imm],
     // so we first do try to take @|label|[.... and we do not consume []
 

crates/zkEVM-assembly/src/assembly/parse/data_element.rs

@@ -68,7 +68,7 @@ fn parse_label_name(input: &str) -> IResult<&str, Vec<DataElement>> {
     Ok(("", vec![DataElement::LabelName(label_name.to_string())]))
 }
 
-fn parse_zeroes<'a>(input: &'a str) -> IResult<&str, usize> {
+fn parse_zeroes<'a>(input: &'a str) -> IResult<&'a str, usize> {
     // we want to parse something `.cell signed_integer`
     // and transform it into the unsigned 32 byte
 
@@ -113,7 +113,7 @@ fn serialize_biguint(input: BigUint) -> Option<[u8; 32]> {
     Some(result)
 }
 
-fn parse_cell<'a>(input: &'a str) -> IResult<&str, BigUint> {
+fn parse_cell<'a>(input: &'a str) -> IResult<&'a str, BigUint> {
     // we want to parse something `.cell signed_integer`
     // and transform it into the unsigned 32 byte
 
@@ -161,7 +161,7 @@ fn parse_cell<'a>(input: &'a str) -> IResult<&str, BigUint> {
     Ok(("", unsigned))
 }
 
-fn parse_name<'a>(input: &'a str) -> IResult<&str, &str> {
+fn parse_name<'a>(input: &'a str) -> IResult<&'a str, &'a str> {
     let mut parser = nom::sequence::tuple::<_, _, nom::error::Error<_>, _>((
         nom::character::complete::space0,
         nom::bytes::complete::tag(".cell"),

crates/zk_evm/src/opcodes/execution/far_call.rs

@@ -429,7 +429,7 @@ impl<const N: usize, E: VmEncodingMode<N>> DecodedOpcode<N, E> {
             #[allow(dropping_references)]
             drop(current_stack_mut);
 
-            let (mut callee_stipend, mut extra_ergs_from_caller_to_callee) =
+            let (callee_stipend, mut extra_ergs_from_caller_to_callee) =
                 get_stipend_and_extra_cost(&called_address, far_call_abi.to_system);
 
             let remaining_ergs_of_caller_frame =

crates/zk_evm/src/reference_impls/memory.rs

@@ -505,22 +505,6 @@ mod tests {
                 .value
         }
 
-        fn read_code_query(&mut self, location: MemoryLocation) -> U256 {
-            assert!(location.memory_type == MemoryType::Code);
-            self.memory
-                .specialized_code_query(
-                    0,
-                    MemoryQuery {
-                        timestamp: Timestamp(0),
-                        location,
-                        value: U256::zero(),
-                        rw_flag: false,
-                        value_is_pointer: false,
-                    },
-                )
-                .value
-        }
-
         fn get_heap_location(&self, index: u32) -> MemoryLocation {
             MemoryLocation {
                 index: MemoryIndex(index),

crates/zkevm_test_harness/Cargo.toml

@@ -10,14 +10,6 @@ keywords.workspace = true
 categories.workspace = true
 description = "ZKsync Era proving utilities"
 
-# [[bin]]
-# name = "circuit_limit_estimator"
-# path = "src/circuit_limit_estimator/main.rs"
-
-# [[bin]]
-# name = "circuit_synthesis_performance_test"
-# path = "src/circuit_synthesis_performance_test/main.rs"
-
 [[bin]]
 name = "geometry_config_generator"
 path = "src/geometry_config_generator/main.rs"