Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix hard static analysis errors #14

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Aug 30, 2024

  • Fixes all the "red" errors (deny by default) observable in the monorepo.
  • Fixes/silences some of the "yellow" errors (there are just too many for a single PR).

The ultimate goal is to enable clippy in CI.

@popzxc popzxc requested a review from 0xVolosnikov August 30, 2024 07:44
Copy link
Contributor

@0xVolosnikov 0xVolosnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@popzxc popzxc merged commit ce50752 into main Aug 30, 2024
6 checks passed
@popzxc popzxc deleted the popzxc-fix-static-analysis branch August 30, 2024 10:34
popzxc pushed a commit that referenced this pull request Sep 6, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.150.5](v0.150.4...v0.150.5)
(2024-09-06)


### Features

* Bump crypto dependencies
([#40](#40))
([407645f](407645f))
* **ci:** Automatic releases on crates.io
([#24](#24))
([24ff829](24ff829))
* Introduce release-please
([#12](#12))
([4bb5cca](4bb5cca))


### Bug Fixes

* Fix hard static analysis errors
([#14](#14))
([ce50752](ce50752))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants