feat: Remove unneeded data and calculations from simulators in witgen #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilLuta
reviewed
Sep 30, 2024
EmilLuta
approved these changes
Sep 30, 2024
shamatar
reviewed
Sep 30, 2024
0xVolosnikov
pushed a commit
that referenced
this pull request
Oct 16, 2024
🤖 I have created a release *beep* *boop* --- ## [0.150.6](v0.150.5...v0.150.6) (2024-10-07) ### Features * Remove unneeded data and calculations from simulators in witgen ([#18](#18)) ([7316caf](7316caf)) * Reorganize witgen ([#49](#49)) ([9bf5cf8](9bf5cf8)) * Use zeroes instead of simulator states as unused part of RAM permutation witness ([#47](#47)) ([a336980](a336980)) ### Bug Fixes * Simplify closed_form_witness_from_full_form ([#38](#38)) ([af3d4c4](af3d4c4)) * **zkevm_test_harness:** Reduce ExtendedLogQuery RAM usage ([#44](#44)) ([eecf79a](eecf79a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, simulators collect/produce some data that is not used in any way. This PR removes this, and also simplifies a little bit simulators themselves and the associated data structures.
First step in RAM witnesses overhaul