-
Notifications
You must be signed in to change notification settings - Fork 0
fix: bump cactus parser chart version and disable OTel metric pushing by default #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds the ability to disable OpenTelemetry tracing to prevent error spam when the OpenTelemetry dependency is disabled. It introduces an OTEL_ENABLED environment variable set to false by default for both cactus-backend and cactus-parser components.
Changes:
- Added
OTEL_ENABLED: falseenvironment variable to control OpenTelemetry tracing - Updated cactus-backend chart version from 0.5.10 to 0.5.11
- Updated cactus-parser dependency version from 0.0.3 to 0.0.5
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/cactus-backend/values.yaml | Added OTEL_ENABLED: false to both cactus-backend and cactus-parser environment variables |
| charts/cactus-backend/README.md | Added upgrade documentation for version 0.5.11 explaining the new OTEL_ENABLED feature |
| charts/cactus-backend/Chart.yaml | Bumped chart version to 0.5.11 and cactus-parser dependency to 0.0.5 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dataviruset
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we have the override in two places but it's fine, it just shows what's possible to configure, it's a convenience
when opentelemetry dependency is disabled, application should not even try to export traces to it.

so we wont be spammed by errors