Skip to content

Conversation

@shuninghuang
Copy link
Contributor

when opentelemetry dependency is disabled, application should not even try to export traces to it.
so we wont be spammed by errors
Screenshot 2026-02-02 at 18 34 26

@shuninghuang shuninghuang marked this pull request as draft February 2, 2026 10:36
@dataviruset dataviruset requested a review from Copilot February 2, 2026 10:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the ability to disable OpenTelemetry tracing to prevent error spam when the OpenTelemetry dependency is disabled. It introduces an OTEL_ENABLED environment variable set to false by default for both cactus-backend and cactus-parser components.

Changes:

  • Added OTEL_ENABLED: false environment variable to control OpenTelemetry tracing
  • Updated cactus-backend chart version from 0.5.10 to 0.5.11
  • Updated cactus-parser dependency version from 0.0.3 to 0.0.5

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
charts/cactus-backend/values.yaml Added OTEL_ENABLED: false to both cactus-backend and cactus-parser environment variables
charts/cactus-backend/README.md Added upgrade documentation for version 0.5.11 explaining the new OTEL_ENABLED feature
charts/cactus-backend/Chart.yaml Bumped chart version to 0.5.11 and cactus-parser dependency to 0.0.5

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@shuninghuang shuninghuang changed the title fix: bump cactus parser chart version and add OTEL_ENABLED to disable opentelemetry fix: bump cactus parser chart version and add OTEL_ENABLED to disable pushing to opentelemetry Feb 2, 2026
@shuninghuang shuninghuang marked this pull request as ready for review February 2, 2026 11:01
@dataviruset dataviruset changed the title fix: bump cactus parser chart version and add OTEL_ENABLED to disable pushing to opentelemetry fix: bump cactus parser chart version and disable OTel metric pushing by default Feb 2, 2026
Copy link
Contributor

@dataviruset dataviruset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we have the override in two places but it's fine, it just shows what's possible to configure, it's a convenience

@shuninghuang shuninghuang merged commit 3b1ddb6 into main Feb 3, 2026
6 checks passed
@shuninghuang shuninghuang deleted the hotfix/disable-opentelemetry branch February 3, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants