Add explicit classes for structured and unstructured formula variants. #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds explicit classes for the structured and unstructured formula variants. I was on the fence about pulling the trigger on this, but the issues identified in #213 make the increase in local complexity worth it.
This is a largely backward compatible change, unless code is hard-coded to expect structured instance methods like
._map
and_has_structure
. I doubt anyone is using them, but just in case, before merging I will add in backward compatible shims for these methods that raise the appropriate deprecation warnings; and ultimately we'll remove these shims in version 2.0 (whenever that happens). Users need never intentionally interact with the newSimpleFormula
andStructuredFormula
classes.As a result of these changes, code like:
will retain the ordering of the nested formulae rather than reordering them; due to the new distinction between
List[Term]
(which is still reordered according to the local ordering policy) andSimpleFormula
which is responsible for its own ordering.TODO:
Structured
methods and attributes on the newSimpleFormula
class.closes: #213