Take care on non-standard Microsoft XMP tag Rating

Rename it to RatingPercent just like e.g. exiftool does. Resolves: #148
mattiasw · Apr 25, 2021 · 2e5a4a4 · 2e5a4a4
1 parent 1f6f96d
commit 2e5a4a4
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 2 deletions.
diff --git a/dist/exif-reader.js b/dist/exif-reader.js
diff --git a/dist/exif-reader.js.map b/dist/exif-reader.js.map
diff --git a/src/xmp-tags.js b/src/xmp-tags.js
@@ -217,6 +217,9 @@ function isNamespaceDefinition(name) {
 }
 
 function getLocalName(name) {
+    if (/^MicrosoftPhoto(_\d+_)?:Rating$/i.test(name)) {
+        return 'RatingPercent';
+    }
     return name.split(':')[1];
 }
 

diff --git a/test/build/update.js b/test/build/update.js
@@ -1,3 +1,5 @@
+// Add/update a single file:
+//     npm run test:build:update -- --image=<filename without path>
 const path = require('path');
 const fs = require('fs');
 const {execSync} = require('child_process');

diff --git a/test/unit/xmp-tags-spec.js b/test/unit/xmp-tags-spec.js
@@ -726,6 +726,32 @@ describe('xmp-tags', () => {
             }
         });
     });
+
+    describe('exceptions', () => {
+        it('should rename MicrosoftPhoto:Rating to RatingPercent', () => {
+            const xmlString = getXmlString(`
+                <rdf:Description xmlns:tiff="http://ns.adobe.com/tiff/1.0/">
+                    <xmp:Rating>3</xmp:Rating>
+                    <MicrosoftPhoto:Rating>50</MicrosoftPhoto:Rating>
+                    <MicroSoftPhoto_1_:Rating>50</MicroSoftPhoto_1_:Rating>
+                </rdf:Description>
+            `);
+            const dataView = getDataView(xmlString);
+            const tags = XmpTags.read(dataView, [{dataOffset: 0, length: xmlString.length}]);
+            expect(tags).to.deep.equal({
+                Rating: {
+                    value: '3',
+                    attributes: {},
+                    description: '3'
+                },
+                RatingPercent: {
+                    value: '50',
+                    attributes: {},
+                    description: '50'
+                }
+            });
+        });
+    });
 });
 
 function getXmlStringWithPacketWrapper(content) {