Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a typed, predicate-based fetch request API for querying Message and Chat records, as a follow-up to the model changes in #11.
Changes:
- Adds a generic
FetchRequest<Result>API plus typed predicate/sort descriptor enums for messages and chats. - Reworks
Databasefetching to support predicate compilation, sorting, and pagination viafetch(_:), while keeping deprecated legacy convenience wrappers. - Expands test coverage for sorting/pagination, predicate composition, match modes, and pagination validation; updates README examples to the new API.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
Sources/iMessage/FetchRequest.swift |
Adds the new public typed fetch request, predicates, sort descriptors, and defaults for Message/Chat. |
Sources/iMessage/Database.swift |
Implements fetch(_:) for typed requests, predicate compilation to SQL, ORDER BY generation, and pagination validation; keeps deprecated wrappers. |
Tests/iMessageTests/DatabaseTests.swift |
Adds tests covering pagination/sort, predicate composition, match modes, empty-compound semantics, legacy wrapper parity, and invalid pagination. |
README.md |
Updates dependency version and replaces legacy fetch example with the predicate-style FetchRequest usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #11