[YW-360] Debug for time warning#20
Merged
sherryy021229-sys merged 6 commits intomainfrom Oct 23, 2025
Merged
Conversation
sherryy021229-sys
temporarily deployed
to
github-pages
GitHub Actions
Inactive
sherryy021229-sys
requested review from
AdaZhuu,
LuxuryB,
Copilot,
maugus0 and
phutruonnttn
There was a problem hiding this comment.
Pull Request Overview
This PR addresses time-related test warnings by adjusting timeout configurations in test files. The global timeout setting has been removed in favor of per-test timeout configurations to provide more granular control over test execution times.
Key Changes:
- Removed global
jest.setTimeout(20000)in favor of individual test timeouts - Applied specific timeout values (10000ms or 15000ms) to async-heavy tests
- Cleaned up unnecessary TypeScript ignore comments
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/pages/admin/categories/categoryform.test.jsx | Replaced global timeout with individual test timeouts (10-15s) for async operations |
| src/hooks/admin/useexport.test.js | Removed redundant TypeScript ignore comments for URL mock assignments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
AdaZhuu
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debug for time warning