Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: recently spotify played #52

Merged
merged 2 commits into from
Oct 26, 2023
Merged

🐛 fix: recently spotify played #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd9ac21
🐛 fix: recently spotify played
maurodesouza Oct 26, 2023
174cbfe
🐛 fix: build type error
maurodesouza Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/utils/getMusicUrl/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@ const { profileBaseUrl, recentlyPlayedBaseUrl } =

const getMusicUrl = (type: string, props: Obj = {}) => {
if (type === 'recently') {
const { user, ...rest } = props;
const username = user as string | undefined;
const spotifyAccountUrl = (props.user &&
`${profileBaseUrl}/${props.user}`) as string | undefined;

const spotifyAccountUrl = username && `${profileBaseUrl}/${username}`;
const imageUrl = `${recentlyPlayedBaseUrl}?${objectToQueryParams(rest)}`;
const imageUrl = `${recentlyPlayedBaseUrl}?${objectToQueryParams(props)}`;

return { spotifyAccountUrl, imageUrl };
}
Expand Down
2 changes: 1 addition & 1 deletion src/utils/getMusicUrl/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ describe('UTILS - Get music url', () => {

expect: {
profileUrl: `${profileBaseUrl}/test`,
imgUrl: `${recentlyPlayedBaseUrl}?foo=some&here=bla`,
imgUrl: `${recentlyPlayedBaseUrl}?user=test&foo=some&here=bla`,
},
},
];
Expand Down
Loading