Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new blocks to GrapesJS builder #28

Closed

Conversation

volha-pivavarchyk
Copy link
Contributor

@volha-pivavarchyk volha-pivavarchyk commented Mar 27, 2022

Description:

Add additional blocks to the grapesjs builder for mjml emails.

The new blocks are:

  1. sect 37 the section with 2 cells inside: 30% and 70%
  2. text-sect the block with 2 text components, respectively for the heading and paragraph
  3. grid-items the block of 2 components in row
  4. list-items the list of 2 components

Related to the PR #11006

Steps to test:

  1. Create new mjml email or choose an existing one
  2. Open the grapesjs builder
  3. New blocks here

@RCheesley
Copy link
Member

@volha-pivavarchyk could you take a look at the conflict please? Many thanks!

@RCheesley RCheesley added ready-to-test enhancement New feature or request labels Sep 26, 2023
@RCheesley RCheesley changed the title Add new blocks Add new blocks to GrapesJS builder Sep 26, 2023
@LordRembo
Copy link
Contributor

LordRembo commented Jan 31, 2024

I also have 2 PR's for updating GrapesJS in M5 and M4, these also fix the extra blocks in M4 too.

For M4, there's equivalent PR's linked from those M5 PR's

@LordRembo
Copy link
Contributor

Ideally, we merge those updates and can close this one.

@LordRembo
Copy link
Contributor

Ah, even better, looks like the addition of the blocks is already in the latest version of this preset. Probably via another PR?
@volha-pivavarchyk could you perhaps pull in the main or 5.x branch and confirm that this is the case?
Then we can close this PR

@LordRembo LordRembo assigned LordRembo and unassigned LordRembo Jan 31, 2024
@LordRembo LordRembo self-requested a review January 31, 2024 11:27
@LordRembo LordRembo added the question Further information is requested label Jan 31, 2024
@volha-pivavarchyk
Copy link
Contributor Author

@LordRembo sure I'll check. But I can do it only at the weekend.

@volha-pivavarchyk
Copy link
Contributor Author

@LordRembo In fact, these changes have already been added. This PR can be closed

@volha-pivavarchyk
Copy link
Contributor Author

The changes have been added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed enhancement New feature or request question Further information is requested ready-to-test
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants