-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update grapesjs compatibility (Mautic 5 + CKE5) #51
Update grapesjs compatibility (Mautic 5 + CKE5) #51
Conversation
Hmm, I found an issue when loading GrapesJS, that traces back to the Editorfonts service from the preset. Gonna have to investigate a bit. |
Okay, so it's not directly related to the changes in this PR but to updates in GrapesJS, combined with the CKE5 stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is this PR ready to review? I'm not sure based on your last comment.
- If it is, it looks like most of the changes are mostly code style changes. Were those changes done by a script?
- What changes were done by hand? Those outside of the dist directory?
- Is there a way to test these changes?
|
Cool! Another question is why we need #49. Can we just merge this into the 5.x branch? |
Ah, yeah, I made this PR before the |
No, it's the other way around. This PR has to be closed because it is targetting the cke5 branch that was already merged. The changes are now for #49 |
This PR is specific for the ckeditor5 branch, so we can use the updated preset in 5.x
Registering your custom components using the legacy method breaks when updating GrapesJS to release 0.20.1. Need this to be able to upgrade GrapesJS in the GrapesJSBuilderBundle.
Related PR's: