Skip to content

Commit

Permalink
Merge pull request #22 from mavenlink/IE-516-ruby-3-0-6
Browse files Browse the repository at this point in the history
Ie 516 Update to be compatible with Ruby 3
  • Loading branch information
ncperry authored Feb 2, 2024
2 parents 5549cca + 0db581f commit 6a5071b
Show file tree
Hide file tree
Showing 7 changed files with 39 additions and 10 deletions.
33 changes: 33 additions & 0 deletions .github/workflows/rspec.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: CI

on: [pull_request]

jobs:
rspec:
runs-on: ubuntu-latest
environment: test
container:
image: ruby:3.0.6

steps:
- uses: actions/checkout@v1

- name: Gem cache
id: cache-bundle
uses: actions/cache@v1
with:
path: vendor/bundle
key: bundle-${{ hashFiles('**/Gemfile.lock') }}

- name: Bundle install
env:
RAILS_ENV: test
run: |
gem install bundler
bundle install
- name: Run tests
env:
RAILS_ENV: test
run: |
bundle exec rspec
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,4 @@ test/version_tmp
tmp
vendor/
.idea/
.ruby-version
1 change: 0 additions & 1 deletion .ruby-version

This file was deleted.

6 changes: 1 addition & 5 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,5 @@ gem 'pry-nav'
gem 'pry-rescue'

# optional dependency for more accurate timezone conversion
gem 'tzinfo', '1.2.5'
# gem 'tzinfo', '2.0.0'

# required for CircleCI to build properly with ruby 1.9.3
gem 'json', '~> 1.8.3'
gem 'tzinfo', '2.0.6'
gem 'rack', '~> 1.6.4'
2 changes: 1 addition & 1 deletion lib/netsuite/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Netsuite
VERSION = '0.7.9'
VERSION = '0.7.10'
end
2 changes: 1 addition & 1 deletion netsuite.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ Gem::Specification.new do |gem|

gem.add_dependency 'savon', '>= 2.3.0'

gem.add_development_dependency 'rspec', '~> 3.1.0'
gem.add_development_dependency 'rspec', '~> 3.12.0'
end
4 changes: 2 additions & 2 deletions spec/netsuite/configuration_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@

context 'when the wsdl has not been set' do
it 'returns a path to the WSDL to use for the API' do
expect(config.wsdl).to eq("https://webservices.netsuite.com/wsdl/v2015_1_0/netsuite.wsdl")
expect(config.wsdl).to eq("https://webservices.netsuite.com/wsdl/v2023_1_0/netsuite.wsdl")
end
end

Expand Down Expand Up @@ -290,7 +290,7 @@
describe '#api_version' do
context 'when no api_version is defined' do
it 'defaults to 2015_1' do
expect(config.api_version).to eq('2015_1')
expect(config.api_version).to eq('2023_1')
end
end
end
Expand Down

0 comments on commit 6a5071b

Please sign in to comment.