Merge branch 'fix-blank' into add-employee-billing-type

Co-authored-by: Jared Nielson <jnielson@mavenlink.com>
Co-authored-by: Dezeray Kowalski <dkowalski@mavenlink.com>

lib/netsuite/actions/delete_list.rb

@@ -62,7 +62,7 @@ def response_list
       end
 
       def success?
-        @success ||= response_errors.blank?
+        @success ||= (response_errors.nil? || response_errors.empty?)
       end
 
       def response_errors
@@ -101,4 +101,4 @@ def delete_list(options = { }, credentials={})
       end
     end
   end
-end
+end

lib/netsuite/configuration.rb

@@ -167,7 +167,7 @@ def soap_header(headers = nil)
     end
 
     def auth_header(credentials={})
-      if !credentials[:consumer_key].blank? || !consumer_key.blank?
+      if !credentials[:consumer_key].to_s.empty? || !consumer_key.to_s.empty?
         token_auth(credentials)
       else
         user_auth(credentials)

spec/netsuite/actions/delete_list_spec.rb

@@ -76,6 +76,9 @@
 
       it 'constructs error objects' do
         response = NetSuite::Actions::DeleteList.call([klass, :list => customer_list_with_error])
+
+        expect(response).to_not be_success
+
         expect(response.errors.keys).to match_array(customer_with_error.internal_id)
         expect(response.errors[customer_with_error.internal_id].first.code).to eq('USER_EXCEPTION')
         expect(response.errors[customer_with_error.internal_id].first.message).to eq('Invalid record: type=event,id=100015,scompid=TSTDRV96')