Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add mounted in addPostFrameCallback #1557

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

YassinNouh21
Copy link
Contributor

@YassinNouh21 YassinNouh21 commented Jan 25, 2025

this issue: #1430

This pull request includes a small change to the lib/src/pages/quran/page/reciter_selection_screen.dart file. The change ensures that the reciteNotifierProvider is read only if the widget is mounted.

@YassinNouh21 YassinNouh21 self-assigned this Jan 25, 2025
@YassinNouh21 YassinNouh21 added the bug Something isn't working label Jan 25, 2025
Copy link
Contributor

@ghassenbenzahra123 ghassenbenzahra123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YassinNouh21 YassinNouh21 merged commit 016f9ef into release-1.20 Jan 30, 2025
1 check passed
@YassinNouh21 YassinNouh21 deleted the fix/ref_in_reciter_selection branch January 30, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StateError: Bad state: Cannot use "ref" after the widget was disposed.
2 participants