Closed
Conversation
|
Any update? |
dpslwk
reviewed
Dec 21, 2019
src/DoctrineQueueProvider.php
Outdated
| return new Worker($app['queue'], $app['events'], | ||
| $app['em'], $app['Illuminate\Contracts\Debug\ExceptionHandler']); | ||
| $isDownForMaintenance = function () { | ||
| return $app->isDownForMaintenance(); |
There was a problem hiding this comment.
this should be return $this->app->isDownForMaintenance();
|
@maxbrokman could we get this merged please? |
|
Hey @motia , i'm getting following error while using this PR After disabled exception got null argument error Seems you can't pass callable function twice to public function __construct(
QueueManager $manager,
Dispatcher $events,
EntityManager $entityManager,
ExceptionHandler $exceptions
) {
$isDownForMaintenance = function () {
return app()->isDownForMaintenance();
};
parent::__construct($manager, $events, $exceptions, $isDownForMaintenance);
$this->entityManager = $entityManager;
} |
Add support for Laravel 7.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I have updated the code to support laravel 6.
I did not find any major changes besides those of the constructors of the Worker and WorkerCommand base classes. So this PR has breaking changes to laravel 5 and it would be best to put it in a 0.4 branch.
Also, I had to swap the php-cs-fixer as the old version did not support php7 and was moved to another repository.
Thank you.