-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Laravel 6.0 #24
Conversation
Any update? |
src/DoctrineQueueProvider.php
Outdated
return new Worker($app['queue'], $app['events'], | ||
$app['em'], $app['Illuminate\Contracts\Debug\ExceptionHandler']); | ||
$isDownForMaintenance = function () { | ||
return $app->isDownForMaintenance(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be return $this->app->isDownForMaintenance();
@maxbrokman could we get this merged please? |
Hey @motia , i'm getting following error while using this PR
After disabled exception got null argument error
Seems you can't pass callable function twice to public function __construct(
QueueManager $manager,
Dispatcher $events,
EntityManager $entityManager,
ExceptionHandler $exceptions
) {
$isDownForMaintenance = function () {
return app()->isDownForMaintenance();
};
parent::__construct($manager, $events, $exceptions, $isDownForMaintenance);
$this->entityManager = $entityManager;
} |
Add support for Laravel 7.x
Hi, I have updated the code to support laravel 6.
I did not find any major changes besides those of the constructors of the Worker and WorkerCommand base classes. So this PR has breaking changes to laravel 5 and it would be best to put it in a 0.4 branch.
Also, I had to swap the php-cs-fixer as the old version did not support php7 and was moved to another repository.
Thank you.