Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to always save session #216

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

0rzech
Copy link
Contributor

@0rzech 0rzech commented Aug 26, 2024

This will allow to prolong session validity period with every valid request at the cost of higher session store write activity and adding set-cookie header to each response.

This will allow to prolong session validity period with every valid
request at the cost of higher session store write activity and adding
set-cookie header to each response.
src/service.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.80%. Comparing base (02e4c55) to head (5b4fff4).
Report is 1 commits behind head on main.

Files Patch % Lines
src/service.rs 63.63% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   84.54%   83.80%   -0.75%     
==========================================
  Files           5        5              
  Lines         343      352       +9     
==========================================
+ Hits          290      295       +5     
- Misses         53       57       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0rzech 0rzech force-pushed the save-session-on-read branch 2 times, most recently from 5bfeaaf to dcf3ace Compare August 26, 2024 16:54
@maxcountryman maxcountryman merged commit fe33b77 into maxcountryman:main Aug 26, 2024
5 of 7 checks passed
@maxcountryman
Copy link
Owner

Thanks for this!

@0rzech
Copy link
Contributor Author

0rzech commented Aug 26, 2024

You're welcome and thank you for your hard work! 🚀 😃

@0rzech 0rzech deleted the save-session-on-read branch August 26, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants