Add Overlay Binding Notification on Game Start #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WSSDude
requested changes
Dec 14, 2024
| @@ -195,12 +197,40 @@ void Overlay::Update() | |||
| } | |||
| } | |||
|
|
|||
| // Display binding in bottom right corner for 5 seconds | |||
| if (!Bindings::IsFirstTimeSetup() && !m_bindHintShown) | |||
There was a problem hiding this comment.
I would rather do something like in feature/notifications branch instead of this, and consider expanding it to sol_ImGui for mods to use.
Maybe even add some setting for the type of spdlog loglevel to notify about and automatically notify when someone logs something. Could be very useful for mods and also internal errors.
The branch needs tweaking, is just a starting point basically reimplementing this PR. It has issues with close button looking weird (probably collision with our style vs. default ImGui style the ImGuiNotify expects...) and is missing license in ThirdParty_LICENSE file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took us 4 years, but this commit adds an small notification to the bottom left of the screen with the current bind to remind people what it was set to.
Example shown in Discord: https://discord.com/channels/717692382849663036/795081899756224572/1300137119255232573