Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various missing method or class loading due to ASF update #111

Merged
merged 10 commits into from
Dec 4, 2024
Merged

Fix various missing method or class loading due to ASF update #111

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6f55098
Added logging on GithubPluginUpdater
maxisoft Oct 13, 2024
a5dd91b
fixing #110 by removing ToArray() calls
maxisoft Dec 3, 2024
c42f356
Use ThreadLocal instead of AsyncLocal + remove async for quick & dirt…
maxisoft Dec 3, 2024
cd227b6
Use a workaround class To replace AsyncLocal
maxisoft Dec 3, 2024
9529b50
Remove AsArray calls
maxisoft Dec 3, 2024
3aa01e5
Bugfix RedditHelper for issue #110
maxisoft Dec 3, 2024
ca6c407
BugFix ASFFreeGamesOptionsLoader #110
maxisoft Dec 3, 2024
57116da
Bump version to 1.8.1
maxisoft Dec 3, 2024
3073fc3
remove severity of CA1859
maxisoft Dec 3, 2024
2d49d75
Remove windows for publish actions as it's buggy right now
maxisoft Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bugfix RedditHelper for issue #110
  • Loading branch information
@maxisoft
maxisoft committed Dec 3, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 3aa01e5cd397f68b5d0ffee1a6ef21cf4e99e828
2 changes: 1 addition & 1 deletion ASFFreeGames/Reddit/RedditHelper.cs
View file
Original file line number Diff line number Diff line change
@@ -43,7 +43,7 @@ IReadOnlyCollection<RedditGameEntry> returnValue() {
}

// ReSharper disable once LoopCanBePartlyConvertedToQuery
foreach (JsonNode? comment in children.AsArray()) {
foreach (JsonNode? comment in (JsonArray) children) {
JsonNode? commentData = comment?["data"];

if (commentData is null) {